Fix infinite searching for .swift-format file on Linux #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ahoppen requested review from allevato, bnbarham and shawnhyam as code owners 
shawnhyam approved these changes Oct 11, 2024
bnbarham approved these changes Oct 11, 2024
allevato approved these changes Oct 11, 2024
Due to swiftlang/swift-foundation#980, the we may end up with a `path == ""` instead of `/`. We didn’t catch this in the test because we only end up with an empty path when searching for a `.swift-format` file from a `.swift-file` that was not at the root of a directory.
ahoppen force-pushed the infinite-searching-linux branch from 3e9e9a0 to ba8f585 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Due to swiftlang/swift-foundation#980, the we may end up with a
path == ""instead of/.We didn’t catch this in the test because we only end up with an empty path when searching for a
.swift-formatfile from a.swift-filethat was not at the root of a directory.