Compile all quantifications using a generalized (with specializations) quant algorithm #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
milseman force-pushed the risc_assessment branch 2 times, most recently from 7842bfd to fa209fa Compare Member Author
| Pushed what should be (modulo bugs) all quantification kinds and amounts. |
milseman changed the title Member Author
| @swift-ci please test linux platform |
This was referenced Dec 22, 2021
rxwei approved these changes Dec 23, 2021
Contributor
rxwei left a comment
rxwei left a comment There was a problem hiding this comment.
LGTM with just some minor nits
Supports all number and kinds of quantifications found in regex. BUG: There is a bug wherein reluctant restores are re-entrant, potentially failing to restore the loop trip count registers.
milseman force-pushed the risc_assessment branch from 1e2e0b3 to f0f51e9 Compare Member Author
| @swift-ci please test linux |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds a general purpose quantification algorithm with specializations for common bounds (
0,1,unbounded).Expands testing.
Overhauls some parts of ME's instruction and operand structure.
Note that we continue to suffer from reluctant restores being reentrant, at least as long as we have non-restorable state such as global register values.