Tweak libswiftLexRegexLiteral interface #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Update so it would have the ability to better recover from lexing errors in the future.
hamishknight force-pushed the tweak-interface branch from 077d89b to 7353d36 Compare 
Contributor Author
| @swift-ci please test Linux |
Contributor Author
| @milseman I added a couple of extra platforms to the |
milseman approved these changes Dec 17, 2021
Member
milseman left a comment
milseman left a comment There was a problem hiding this comment.
LGTM for now. We'll eventually want a model of a diagnostics engine for the future, because we want to be able to issue notes and fixits and warnings, but this is a good lexing interface. The latter can be added to the parsing interface.
Member
| @swift-ci please test linux platform |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
From the review feedback on swiftlang/swift#40595, update the interface here so it would have the ability to better recover from lexing errors in the future.