[swift/main] Fix word boundary matching in matches(of:) #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
A prior change incorrectly treated the start of the `searchBounds` as an always-valid word boundary, which resulted in a word boundary at the start of a pattern unconditionally matching at the restart point when finding all matches in a string. This change corrects the usage to recognize word boundaries only at the start of the `subjectBounds`. rdar://129417643
| @swift-ci Please test |
stephentyrone approved these changes Jun 10, 2024
| @swift-ci Please test |
| @swift-ci Please test Windows platform |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Cherry pick of #744 for
swift/mainbranch.