Skip to content

ParseableInterface test failure workaround (#73) #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milseman merged 1 commit into from
Dec 14, 2021
Merged

ParseableInterface test failure workaround (#73) #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
ParseableInterface test failure workaround (#73) 
Disables `RangeReplaceableCollection` conformance for now until we find a way to declare a conformance without triggering #73.
  • Loading branch information
@rxwei
rxwei committed Dec 14, 2021
commit e04c9bccc7978d330c82f41b36671a986bf2532c
12 changes: 12 additions & 0 deletions Sources/_MatchingEngine/Utility/TypedIndex.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ extension TypedIndex: BidirectionalCollection where C: BidirectionalCollection {
Index(rawValue.index(before: before.rawValue))
}
}

// FIXME(apple/swift-experimental-string-processing#73): ParseableInterface test
// failure in the Swift repo.
#if false
extension TypedIndex: RangeReplaceableCollection where C: RangeReplaceableCollection {
@_alwaysEmitIntoClient
public init() { rawValue = C() }
Expand All @@ -88,6 +92,14 @@ extension TypedIndex: RangeReplaceableCollection where C: RangeReplaceableCollec

// TODO: append, and all the other customization hooks...
}
#endif

// Workaround for #73
extension TypedIndex where C: RangeReplaceableCollection {
public mutating func append(_ newElement: Element) {
rawValue.append(newElement)
}
}

extension TypedIndex: ExpressibleByArrayLiteral where C: ExpressibleByArrayLiteral & RangeReplaceableCollection {
@_alwaysEmitIntoClient
Expand Down