Refactor/rename source locations, tracking, etc #67
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Track source locations for Atoms, quantifier sub-values (like ranges and modifiers), and other refactoring and changes.
Naming convention:
Source.Position: A dimensionless point in the inputSource.Location: The region of the input from which a parsed entity cameSourceLocationtypealiasAST.Loc/Source.Loc: a located value, that is a value with a location.AST builders and faking:
_StringProcessingmodule_fakeglobals removed in favor of static members or inits onSourceLocationatom_mmakes the custom char set member variant instead of the AST variantChanges to AST or parser functionality:
After this PR, there's only a handful of minor things to track:
|in alternations-in ranges inside custom character classes)tracked separately, though that's derivable from the group's range\Qand\Edistinct from the contents of the quote^for inverting Unicode properties inside a\p{^...}a{3,7}