Add an AllScalars collection #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| 🥳 We'll definitely want to sneak this into a pitch sometime. |
Contributor
| Did this patch pass CI? There's a test failure on main. /home/buildnode/jenkins/workspace/pr-swift-experimental-string-processing-linux/branch-main/swift-experimental-string-processing/Tests/UtilTests/AllScalarsTests.swift:27: error: AllScalarsTests.testProperties : XCTAssertEqual failed: ("650") is not equal to ("630") - 19:17:19 /home/buildnode/jenkins/workspace/pr-swift-experimental-string-processing-linux/branch-main/swift-experimental-string-processing/Tests/UtilTests/AllScalarsTests.swift:32: error: AllScalarsTests.testProperties : XCTAssertEqual failed: ("2925.0") is not equal to ("2835.0") - 19:17:19 Test Case 'AllScalarsTests.testProperties' failed (1.537 seconds) 19:17:19 Test Suite 'AllScalarsTests' failed at 2021-10-23 02:17:15.794 19:17:19 Executed 1 test, with 2 failures (0 unexpected) in 1.537 (1.537) seconds 19:17:19 Test Suite 'Selected tests' failed at 2021-10-23 02:17:15.794 19:17:19 Executed 1 test, with 2 failures (0 unexpected) in 1.537 (1.537) seconds 19:17:19 Build step 'Execute shell' marked build as failure |
Member Author
| Works on my machine™! Those test results could easily be dependent on Unicode version... I'll change them to just test stable things, sorry about that! |
Member Author
Member
| We could phrase that concern as a |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.