Introduce tryCapture(_:). #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
Member
| Should we have a throw abort? That's the pattern we're planning to follow elsewhere and Perl/PCRE's more general-form callouts have that capability. |
Member
| If this passes your local testing, I'm ok merging this. @shahmishal any idea why Linux CI can't get us a machine? We run in around 1min total time, so we're not going to clog up any pipelines. |
Contributor Author
| I haven't triggered tests here, as #119 needed to be merged first. |
`tryCapture(_:)` works like `capture(_:)` but accepts an optional or throwing capture transform instead. When the transform fails (returns `nil` or throws), it will cause matching to fail. This works well with failable conversion initializers such as `Int.init?(_:)`, `Unicode.Scalar.init?(_:)`, etc. ---- Example: With `tryCapture`, the following example avoids unnecessary levels of optionals and double optionals. ```swift line.match { OneOrMore(.hexDigit).tryCapture(Unicode.Scalar.init(hex:)) Optionally { ".." OneOrMore(.hexDigit).tryCapture(Unicode.Scalar.init(hex:)) } OneOrMore(.whitespace) ";" OneOrMore(.whitespace) OneOrMore(.word).tryCapture(Unicode.GraphemeBreakProperty.init) Repeat(.any) } // Regex<(Substring, Unicode.Scalar, Unicode.Scalar?, Unicode.GraphemeBreakProperty)> ``` Contributor Author
| @swift-ci please test Linux |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
tryCapture(_:)works likecapture(_:)but accepts an optional or throwing capture transform instead. When the transform fails (returnsnilor throws), it will cause matching to fail. This works well with failable conversion initializers such asInt.init?(_:),Unicode.Scalar.init?(_:), etc.Example:
With
tryCapture, the following example avoids unnecessary levels of optionals and double optionals.