Treat range quantifiers as literal if invalid #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Allow e.g `"\""`
This matches the PCRE and Oniguruma behavior. Also make sure the matching engine can handle a 0 range.
Contributor Author
| @swift-ci please test Linux |
milseman approved these changes Jan 11, 2022
| diagnose(#"\Qab\"#, expecting: .expected("\\E")) { _ = try $0.lexQuote() } | ||
| diagnose(#""ab"#, expecting: .expected("\""), .experimental) { _ = try $0.lexQuote() } | ||
| diagnose(#""ab\""#, expecting: .expected("\""), .experimental) { _ = try $0.lexQuote() } | ||
| diagnose(#""ab\"#, expecting: .unexpectedEndOfInput, .experimental) { _ = try $0.lexQuote() } |
Member
There was a problem hiding this comment.
Nice, these kinds of tests are coming along nicely!
| return .range(l, u) | ||
| | ||
| case (nil, nil, _?): | ||
| fatalError("Didn't lex lower bound, but lexed upper bound?") |
Member
There was a problem hiding this comment.
At some point, we should do a pass over the codebase and convert unreachable fatalErrors to unreachable throws, differentiating them from diagnostics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This matches the PCRE and Oniguruma behavior. In addition, allow escaped quotes in experimental syntax, allowing for e.g
"\"".