Derive supplementary output paths using the full basename of .swiftmodule #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…dule rdar://70584224
| @swift-ci please test |
artemcm approved these changes Oct 22, 2020
| } | ||
| | ||
| return parentPath.appending(component: moduleName).replacingExtension(with: type) | ||
| return parentPath.appending(component: moduleOutputPath.basename).replacingExtension(with: type) |
There was a problem hiding this comment.
This function doesn't need to take moduleName as a parameter anymore.
There was a problem hiding this comment.
It still needs moduleName in the last return statement
There was a problem hiding this comment.
Oh oops, just looked up, thought this was the last one.
| | ||
| func testDeriveSwiftDocPath() throws { | ||
| var driver = try Driver(args: [ | ||
| "swiftc", "-emit-module", "/tmp/main.swift", "-emit-module-path", "test-ios-macabi.swiftmodule" |
There was a problem hiding this comment.
What is module name in this case? main? Just wondering how off it was.
There was a problem hiding this comment.
I think main will be the default name if not given at all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
rdar://70584224