[6.2] PrebuiltModuleGen: print entire compiler invocation for failed module generation job #1913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… generation job rdar://152342109
| @swift-ci please smoke test |
bnbarham approved these changes Jun 2, 2025
| @swift-ci please test |
| @swift-ci please test Windows |
1 similar comment
| @swift-ci please test Windows |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Cherry-picking: #1910
Explanation: Without this change, the build log of a failing prebuilt module generation job doesn't contain the stack trace if the underlying compiler invocation crashed, adding extra process for triaging the failure. This change teaches the tool to emit crash trace to the build log.
Scope: Swift prebuilt module generation.
Risk: None. This is to add more diagnostics to an already-failing task
Testing: Tested locally that build logs are now with failing compiler invocations
Issue: rdar://152342109
Reviewer: @artemredkin