[6.2][Test-Only] Remove a check for compiler side diagnostics #1884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
cachemeifyoucan commented Apr 29, 2025
cachemeifyoucan commented - Explanation: Remove a check that on the diagnostic message that is on the swift compiler side, that should out of scope of the test.
- Scope: To enable future cherry-picks of the swift compiler change that update the message.
- Issues: N/A
- Original PRs:[Tests] Remove a check for compiler side diagnostics #1882
- Risk:Low. Test Only change.
- Testing: N/A
- Reviewers: @artemcm
Remove a check for the exact diagnostics message from the compiler side as it is out of scope for the test and it prohibits improvements to the diagnostics message from the compiler. (cherry picked from commit 6635337)
| @swift-ci please test |
| This blocks swiftlang/swift#81245 Ping for review |
akyrtzi approved these changes May 6, 2025
| @nkcsgexi Can I get a merge for this change? |
DougGregor approved these changes May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.