Skip to content

Conversation

@cwakamo
Copy link
Contributor

@cwakamo cwakamo commented Mar 12, 2025

…ch takes env and executor parameters (in addition to what V2 takes).

This allows clients of swift-driver which need a custom environment (e.g. to specify the path to libSwiftScan or swift-frontend) or which need a custom executor to get a single frontend invocation given a set of driver arguments. This commit also promotes SimpleExecutor to @_spi(Testing) public from internal so it can be used in tests of this new function.

This addresses rdar://problem/146875054.

…ch takes `env` and `executor` parameters (in addition to what V2 takes). This allows clients of swift-driver which need a custom environment (e.g. to specify the path to libSwiftScan or swift-frontend) or which need a custom executor to get a single frontend invocation given a set of driver arguments. This commit also promotes SimpleExecutor to `@_spi(Testing) public` from `internal` so it can be used in tests of this new function. This addresses <rdar://problem/146875054>.
@cwakamo cwakamo added the enhancement New feature or request label Mar 12, 2025
@cwakamo cwakamo requested review from artemcm and nkcsgexi March 12, 2025 22:46
@cwakamo cwakamo self-assigned this Mar 12, 2025
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@cwakamo
Copy link
Contributor Author

cwakamo commented Mar 12, 2025

@swift-ci please test

@cwakamo cwakamo merged commit 2be4e73 into swiftlang:main Mar 13, 2025
3 checks passed
@cwakamo cwakamo deleted the eng/PR-146875054-add-more-parameters-getSingleFrontendInvocationFromDriverArguments branch March 13, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

2 participants