Skip testLinkFilelistWithDebugInfo off of macOS #1802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Only the Apple-platforms support dsymutil and building/linking with the swiftmodule, therefore, this test only applies to running on macOS where we have dsymutil. I've also cleaned up the test a bit to make it a bit clearer what the goals were. We're trying to verify that the contents of the filelist passed into the link job contains only the expected object file and does not include the swiftmodule file. Fixes: rdar://144378596
| @swift-ci please test |
| Windows Test Failure: |
| @swift-ci please test Windows |
1 similar comment
| @swift-ci please test Windows |
artemcm approved these changes Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Only the Apple-platforms support dsymutil and building/linking with the swiftmodule, therefore, this test only applies to running on macOS where we have dsymutil. I've also cleaned up the test a bit to make it a bit clearer what the goals were.
We're trying to verify that the contents of the filelist passed into the link job contains only the expected object file and does not include the swiftmodule file.
Fixes: rdar://144378596