[6.0 🍒][SwiftScan] Fix headerDependencies in SwiftPrebuiltExternalModuleDetails #1634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Due to C API renaming, swift-driver failed to record the bridging header path from a binary swift module dependencies. Fix the issue by supporting both old and new C APIs for querying bridging header path. rdar://129703095
| @swift-ci please test |
artemcm approved these changes Jun 12, 2024
artemcm changed the title 
cachemeifyoucan changed the title cachemeifyoucan changed the title 
nkcsgexi approved these changes Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Explanation: Fix a bug in swift-driver that after a C API rename, the bridging header path can no longer be queried from dependency graph returned from scanner and always be empty.
Scope: This affects builds that depends on the information that is missing now.
Issue: rdar://129703095
Original PR: #1633
Risk: Low. The fix supports both version of C API.
Test: UnitTest
Reviewer: @artemcm