Schedule an emit-module-separately job even if an input is not compilable #1588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…able The following invocation should schedule an emit-module-separately job for src.swift and include other.dylib in the link job. ``` swiftc -emit-library src.swift other.dylib ``` rdar://127238278
| @swift-ci Please test |
etcwilde reviewed Apr 29, 2024
| | ||
| let emitJob = try plannedJobs.findJob(.emitModule) | ||
| XCTAssertTrue(emitJob.commandLine.contains(try toPathOption("foo.swift"))) | ||
| XCTAssertFalse(emitJob.commandLine.contains(try toPathOption("bar.dylib"))) |
There was a problem hiding this comment.
Why is the dylib an input to the emit module job at all? This seems dangerously close to the behavior of the old driver, which would sometimes pass static archives to the frontend which ends in much sadness.
There was a problem hiding this comment.
I can imagine it being bad, but I think this is fine. Did you notice the XCTAssertFalse for bar.dylib?
There was a problem hiding this comment.
Oh, no, sorry, misread it as XCTAssertTrue, which concerned me. You're good, carry on.
Fixes the failure in testDependencyScanningPathRemap.
| @swift-ci Please test |
| @swift-ci Please test |
| @swift-ci Please test Windows |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The following invocation should schedule an emit-module-separately job for src.swift and include other.dylib in the link job.
rdar://127238278