[6.0][Tests] Support for binary module validation in scanner #1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fix all the tests that expect building module from interface even when the binary module is up-to-date after the swift scanner behavior change. (cherry picked from commit 4864513)
| @swift-ci please test |
| @swift-ci please test windows platform |
cachemeifyoucan changed the title 
nkcsgexi approved these changes Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Explanation:
Fix test failures on swift-6.0 branch due to missing a cherry-pick from test fixes that should come with swift compiler changes. The swift 6.0 test passes because sometimes the swift-driver test failure doesn't return error status and can return success for PR testing.
Original PR: #1563
Risk: Low. Only test update
Testing: UnitTest
Reviewed By: @artemcm