[SwiftCaching] Don't drop -Xcc during dependency scanning #1501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @swift-ci please test |
benlangmuir approved these changes Dec 8, 2023
artemcm approved these changes Dec 8, 2023
When using swift caching, `-Xcc` should not be appended to compilation commmands because dependency scanner returns the cc1 command needed to create clang importer. But `-Xcc` options were accidentally dropped from scan-dependencies command, causing them to be ignored. rdar://119391228
cachemeifyoucan force-pushed the eng/PR-119391228 branch from 573c514 to 99f1c1b Compare | @swift-ci please test |
| @swift-ci please test windows platform |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When using swift caching,
-Xccshould not be appended to compilation commmands because dependency scanner returns the cc1 command needed to create clang importer. But-Xccoptions were accidentally dropped from scan-dependencies command, causing them to be ignored.rdar://119391228