Skip to content

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Dec 7, 2023

We can now vendor the dependencies allowing us to build a separate copy of the dependencies when building the package if it is not provided for. This enables building the package standalone for debugging in scenarios where SPM is unable to build the package (e.g. due to incorrect linking).

We can now vendor the dependencies allowing us to build a separate copy of the dependencies when building the package if it is not provided for. This enables building the package standalone for debugging in scenarios where SPM is unable to build the package (e.g. due to incorrect linking).
@compnerd compnerd requested review from artemcm and etcwilde December 7, 2023 17:46
@compnerd
Copy link
Member Author

compnerd commented Dec 7, 2023

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Dec 7, 2023

@swift-ci please test Windows platform

1 similar comment
@compnerd
Copy link
Member Author

compnerd commented Dec 8, 2023

@swift-ci please test Windows platform

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Reminder that CI here does not exercise the CMake build, cross-repo testing from swift can help exercising the new CMake code.

@compnerd
Copy link
Member Author

Right, this actually is not going to be exercised in that path either. This is in support of building this without the toolchain, which is motivated by the need to build and debug the LSP which cannot be built with SPM due to the inability to create libraries.

@compnerd compnerd merged commit 5306a4b into swiftlang:main Dec 12, 2023
@compnerd compnerd deleted the vendor branch December 12, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants