Skip to content

Improve swift-driver test cases to avoid fatal crash #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2023
Merged

Improve swift-driver test cases to avoid fatal crash #1434

merged 2 commits into from
Sep 6, 2023

Conversation

cachemeifyoucan
Copy link
Contributor

Step 1 to fix #1431

  • Remove unnecessary try!: if in the throwable context, just use try. There are two remaining in concurrentPerform that would be good to be removed in the future, the rest are in setup/generic tests, that are probably file.
  • Fix a nil unwrap when using --parallel
@cachemeifyoucan
[Tests] Use try instead of try! in throwable context
ad1809d 
Avoid `try!` that can crash the tests unnecessarily in a throwable context that can just handle the error.
@cachemeifyoucan
[Test] remove temp directory in tearDown instead of deinit
feeec17 
Testcase can be deinit without calling `setUp` in case of something fatal happens. This will cause unwrapping nil during tests if running tests with `--parallel`.
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test
@cachemeifyoucan cachemeifyoucan merged commit 03f3539 into swiftlang:main Sep 6, 2023
@cachemeifyoucan cachemeifyoucan deleted the eng/swift-driver-tests-fatal-errors branch September 6, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@cachemeifyoucan @compnerd @artemcm