Skip to content

Conversation

elsh
Copy link
Contributor

@elsh elsh commented May 30, 2023

Frontend allows unicode chars in package-name. This PR follows the same rule in the driver for consistency.
Resolves rdar://110021211

@elsh elsh requested a review from artemcm May 30, 2023 20:08
@elsh
Copy link
Contributor Author

elsh commented May 30, 2023

@swift-ci test

@elsh elsh requested a review from tshortli May 30, 2023 20:10
elsh added a commit that referenced this pull request May 30, 2023
Frontend already allows them but the same change was not made in driver. This PR fixes that for consistency. Risk: Low. Frontend already allows unicode chars. Original PR: #1367 Reivewers: @artemcm Testing: Modified an existing test to allow unicode chars in package-name Resolves: rdar://110021211
elsh added a commit that referenced this pull request May 30, 2023
 Frontend already allows them but the same change was not made in driver. This PR fixes that for consistency. Risk: Low. Frontend already allows unicode chars. Original PR: #1367 Reivewers: @artemcm Testing: Modified existing tests Resolves: rdar://110021211
@elsh
Copy link
Contributor Author

elsh commented May 30, 2023

@swift-ci test

@elsh
Copy link
Contributor Author

elsh commented May 31, 2023

@swift-ci test windows

@elsh elsh merged commit f66dd67 into main May 31, 2023
@elsh elsh deleted the es-pkg-uni branch May 31, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants