Test: Check result of sysctlbyname #906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Adding testing functions to verify that a uint32 isn't a specific number.
Adding a check to verify that `syscltbyname` didn't fail. If it did, it likely indicates that the `hw.activecpu` syscall doesn't exist. If the call fails, return zero, indicating that we don't know how many cpus are available.
| @swift-ci please test |
compnerd approved these changes Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adding a check to verify that
sysctlbynamedidn't fail indispatch_workqeueu. If it does,activecpuwill contain random garbage. The test will fail, but it isn't clear why.