[android] Use Bionic imports instead where possible #5149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @swift-ci please test |
compnerd reviewed Dec 17, 2024
| #if os(Windows) | ||
| import WinSDK | ||
| #elseif os(Android) | ||
| #elseif canImport(Android) |
There was a problem hiding this comment.
I think that this should still be an os check.
There was a problem hiding this comment.
The two are pretty much equivalent, but I use this to guard imports like this and os(Android) for genuine OS differences that don't involve importing these C functions. I have seen this done for other platforms in the Swift codebase, so I'm following that distinction for Android too.
There was a problem hiding this comment.
This is only done for Darwin platforms because there is a large set of them and we don't have a way to uniformly identify them at once.
compnerd approved these changes Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@compnerd asked that we use this narrower import instead where possible, so this pull does so and was tested natively on Android.