Skip to content

Avoid expanding search path when generating cxx header #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2023
Merged

Avoid expanding search path when generating cxx header #3

merged 1 commit into from
Dec 30, 2023

Conversation

torarnv
Copy link
Contributor

@torarnv torarnv commented Nov 25, 2023

The ARG_SEARCH_PATHS variable is a list, just like SOURCES, and can be referenced directly in add_custom_command.

Expanding the list manually by replacing ; with spaces would result in linker lines with -I/foo\ -I/bar.
@torarnv
Avoid expanding search path when generating cxx header
e4751e4 
The ARG_SEARCH_PATHS variable is a list, just like SOURCES, and can be referenced directly in add_custom_command. Expanding the list manually by replacing ; with spaces would result in linker lines with `-I/foo\ -I/bar`.
@etcwilde etcwilde self-requested a review December 30, 2023 01:34
etcwilde
etcwilde approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM
@etcwilde etcwilde merged commit 516f1f2 into swiftlang:main Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@torarnv @etcwilde