Allow switching the Swift version in expressions #8775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @swift-ci test |
augusto2112 approved these changes May 17, 2024
JDevlieghere approved these changes May 18, 2024
adrian-prantl force-pushed the 126783312-test branch from 58d30e9 to 112c7c4 Compare | @swift-ci test |
kastiglione approved these changes May 20, 2024
| llvm::VersionTuple(version / 100, version % 100); | ||
| } | ||
| if (lang_opts.EffectiveLanguageVersion >= swift::version::Version({6})) | ||
| lang_opts.StrictConcurrencyLevel = swift::StrictConcurrency::Complete; |
There was a problem hiding this comment.
does the compiler not do this when the version is set to >=6? If lldb is doing this, but the compiler isn't, is that going to cause some issues in some cases?
There was a problem hiding this comment.
also, I'm confused by the title. The diff appears to affect StrictConcurrencyLevel, and the language version already appears supported.
There was a problem hiding this comment.
Both excellent questions. I asked, and the compiler sets this flag in an ad-hoc fashion that isn't readily available to reuse. This also seems to be the only flag that behaves this way.
The title is wrong. This just adds a test.
| @swift-ci test linux |
| test with swiftlang/swift#73757 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.