[6.0][IncludeTree] Support -frewrite-includes with include-tree #8583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add necessary PPCallbacks for include directives when the input file is include tree so -frewrite-includes can generate the correct output. rdar://125719747 (cherry picked from commit ad9d39a)
| @swift-ci please test |
cachemeifyoucan changed the title 
akyrtzi approved these changes Apr 18, 2024
nkcsgexi approved these changes Apr 18, 2024
benlangmuir approved these changes Apr 18, 2024
| @nkcsgexi Can you merge for me since I don't have the permission to do that. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Explanation: Add Preprocessor callbacks in clang include tree to support generating embedded header in swift binary module when caching is enabled.
Original PR: #8531
Risk: Low. Only affect experimental swift caching feature.
Testing: UnitTests
Reviewer: @benlangmuir