[DebugInfo] Emit specifiction_of and spare bits mask in debug info #8170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @swift-ci test |
| @swift-ci test macOS |
augusto2112 force-pushed the spare-bits-mask-dwarf branch from 2979fe9 to 490b689 Compare | @swift-ci test |
augusto2112 force-pushed the spare-bits-mask-dwarf branch from 490b689 to 020cd44 Compare | @swift-ci test |
augusto2112 force-pushed the spare-bits-mask-dwarf branch from 020cd44 to d229f19 Compare | @swift-ci test |
adrian-prantl approved these changes Feb 15, 2024
The spare bits mask is a mask of the unused bits that a type may have. Swift uses these on enums to pack extra data when wrapping these enums in other types. Emit this field in LLVM-IR and DWARF.
augusto2112 force-pushed the spare-bits-mask-dwarf branch from d229f19 to d0c5c44 Compare | @swift-ci test |
| @swift-ci test Windows |
1 similar comment
| @swift-ci test Windows |
Add a specification_of attribute to LLVM DebugInfo, which is analogous to DWARF's DW_AT_specification. According to the DWARF spec: "A debugging information entry that represents a declaration that completes another (earlier) non-defining declaration may have a DW_AT_specification attribute whose value is a reference to the debugging information entry representing the non-defining declaration." This patch allows types to be specifications of other types. For example, a templated type where the template parameters are substituted in could be a specification of the non-substituted template type.
| @swift-ci test |
| @swift-ci test Windows |
augusto2112 changed the title adrian-prantl approved these changes Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Commit 1:
Commit 2: