Enable LLVM_ENABLE_ONDISK_CAS for Windows by default #11601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @swift-ci please test |
| This needs to be merged after #11585 |
cachemeifyoucan approved these changes Oct 9, 2025
llvm/CMakeLists.txt Outdated
| option (LLVM_ENABLE_TELEMETRY "Enable the telemetry library. If set to OFF, library cannot be enabled after build (eg., at runtime)" ON) | ||
| | ||
| if(UNIX AND CMAKE_SIZEOF_VOID_P GREATER_EQUAL 8) | ||
| if((UNIX OR WIN32) AND CMAKE_SIZEOF_VOID_P GREATER_EQUAL 8) |
There was a problem hiding this comment.
Actually UNIX OR WIN32 will give you always true I think. Just remove that part of the check.
hjyamauchi force-pushed the stable/21.x-flip-ondisk-flag branch from 00469df to ceb126a Compare | @swift-ci please test |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.