[DNM] Address Sanitizer for Wasm/WASI #10673
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kateinoigakukun force-pushed the yt/swift-wasm-asan branch 2 times, most recently from 21772b1 to 1acf8cb Compare kateinoigakukun force-pushed the yt/swift-wasm-asan branch from f1435f5 to 32c7468 Compare 
Some platforms (like non-Emscripten WebAssembly) do not have the concept of a "return address" in the same way that other platforms do, and `__builtin_return_address` is unavailable.
This change makes `-fsanitize=address` available for WASI target by replicating what we do for Emscripten because they share the same memory model.
The `.syms` files are passed to the linker with `--dynamic-list=` if the file exists, but the linker option is not supported on wasm-ld.
This reverts commit 2a6551e859d1757aa1ef06fc371dd37d971d4275.
kateinoigakukun force-pushed the yt/swift-wasm-asan branch from 95c18df to ee878b6 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is just for building toolchain via xrepo CI