Skip to content

Conversation

qiongsiwu
Copy link

@qiongsiwu qiongsiwu commented Apr 22, 2025

llvm#135703 added a C++ API to the shared cached to diagnose invalid negatively stat cached paths. This PR adds a C API so an external system can take advantage of the diagnostics.

rdar://149147920

@qiongsiwu
Copy link
Author

qiongsiwu commented Apr 22, 2025

Note to reviewers:
The test added here is simply testing that the API is called correctly. llvm#135703 has a test to test for correctly producing the paths. I am not aware of a simple way to test the C-API for its content (i.e. creating a scan where some file s created in the middle to invalidate the negative stat cache). If you are aware of such tests, I am all ears.

Thanks!

@qiongsiwu qiongsiwu requested review from Bigcheese and jansvoboda11 and removed request for Bigcheese April 22, 2025 20:03
@qiongsiwu qiongsiwu requested a review from jansvoboda11 April 24, 2025 17:07
@qiongsiwu qiongsiwu requested a review from jansvoboda11 April 24, 2025 20:58
@qiongsiwu
Copy link
Author

Ping for review. Thanks!

@qiongsiwu qiongsiwu requested a review from jansvoboda11 April 29, 2025 17:08
@qiongsiwu
Copy link
Author

Ping for review. Thanks!

@qiongsiwu
Copy link
Author

@swift-ci please test llvm

@qiongsiwu
Copy link
Author

The test failures are not related to this PR.

@qiongsiwu qiongsiwu merged commit b7aa45c into swiftlang:next May 1, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants