Skip matrix jobs more cleanly (take 2) #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jakepetroules force-pushed the eng/PR-placeholders-take-2 branch from a85375c to 5342437 Compare jakepetroules force-pushed the eng/PR-placeholders-take-2 branch from 5342437 to 4a9475f Compare Contributor Author
| CC @ahoppen @FranzBusch also. |
FranzBusch approved these changes Dec 10, 2025
Member
| Yeah this is essentially what we are doing in NIO. |
shahmishal approved these changes Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Now disabled jobs will just disappear entirely, rather than appear with confusing unexpanded placeholders.
This is a new technique which solves the problems in the original attempt (#183) -- clean skipping, no errors reported in the actions tab, and without the added complexity of a second set of jobs to create the matrices.