Skip to content

Created a decoder handler to deserialize a MemcachedResponse #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 1, 2023
Merged

Created a decoder handler to deserialize a MemcachedResponse #11

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2838923
created a MemcachedResponse decoder
dkz2 May 26, 2023
4ce410d
flags are parsed but not handled
dkz2 May 26, 2023
c2e44ec
soundness fix
dkz2 May 26, 2023
5624259
response status name cleanup
dkz2 May 26, 2023
633e79b
eof not needed
dkz2 May 26, 2023
067a943
accessor not needed
dkz2 May 26, 2023
6ebbea2
Response and decoder refactor
dkz2 May 30, 2023
72b883e
reimpl decoder as state machine
dkz2 May 31, 2023
abb43c8
decoder test clean up
dkz2 May 31, 2023
077d046
no need to move reader in decodeEndOfLine
dkz2 May 31, 2023
9a4f3be
ignore flags
dkz2 May 31, 2023
7e385c3
consume flag but do nothing with it
dkz2 May 31, 2023
b7772ce
revamp of decoder, removed un needed state
dkz2 Jun 1, 2023
250f680
remove unused state, added fatal error
dkz2 Jun 1, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
soundness fix
  • Loading branch information
@dkz2
dkz2 committed May 26, 2023
commit c2e44ec8fe980256bea4639ff0ffc6a3ebb649d3
1 change: 0 additions & 1 deletion Sources/SwiftMemcache/MemcachedResponseDecoder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ struct MemcachedResponseDecoder: ByteToMessageDecoder {
preconditionFailure("Response code could not be read.")
}


// Check if there's a whitespace character, this indicates flags are present
Copy link
Contributor

@FranzBusch FranzBusch May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only flags but also datalen. Just invert the comment to say if there is not a whitespace then we are at the end of the line.
if buffer.readableBytes > 2, buffer.getInteger(at: buffer.readerIndex, as: UInt8.self) == UInt8.whitespace {
Copy link
Contributor

@FranzBusch FranzBusch May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just read the next byte here and then base our decision of that. Also return needMoreData if there is not a single byte readable.
buffer.moveReaderIndex(forwardBy: 1)
Expand Down