Mark atom! allocated Atoms as having a 'static' lifetime and stop refcounting them #10948
+301 −66
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The Clone and Drop routines will treat them like
inlineatoms but their storage will instead be in astaticitem constructed by the macroThis should speed up initialization and access to
atom!values since there is no more lazy lock just. Instead we just take the address of a static and tag it. This does complicateeqandhasha bit as well asas_strto handle the new location.This follows a similar pattern used in turbopack as of vercel/next.js#81994. Things are different here due to the use of
ThinArcfor storage, which required me to introduce a separate struct for the&'static strcase.The motivation is simple, don't refcount values that will never be freed.