Skip to content

Conversation

@CPunisher
Copy link
Member

I think this could introduce more compiler optimization.

Let's wait for the benchmarks

@CPunisher CPunisher requested a review from a team as a code owner April 13, 2025 09:55
@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2025

⚠️ No Changeset found

Latest commit: 0f261df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CPunisher CPunisher changed the title perf(es/parser): replace byte arguments with generic perf(es/parser): replace byte arguments with generics Apr 13, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 13, 2025

CodSpeed Performance Report

Merging #10370 will degrade performances by 2.48%

Comparing CPunisher:04-13-perf/generic-handler (0f261df) with main (a2d3596)

Summary

❌ 1 regressions
✅ 151 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/lints/libs/terser 29.2 ms 30 ms -2.48%
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Good idea, it's slightly faster

@kdy1 kdy1 added this to the Planned milestone Apr 13, 2025
@kdy1 kdy1 merged commit 68f7667 into swc-project:main Apr 13, 2025
166 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.11.21 Apr 14, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants