Skip to content

Conversation

@dummdidumm
Copy link
Member

fixes sveltejs/kit#10245

@benmccann this might be another one for your testing - this might give better lighthouse scores as a result since html is not removed and reappended anymore if everything matches.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benmccann this might be another one for your testing - this might give better lighthouse scores as a result since html is not removed and reappended anymore if everything matches.

I've only got a single @html on my site and don't see it sticking out during hydration, so don't think I'd notice the impact of this PR from a performance standpoint. The only other thing that's jumping out to me from a performance standpoint is wondering what the call to init is doing.

@dummdidumm dummdidumm merged commit d2ff04f into master Jul 3, 2023
@dummdidumm dummdidumm deleted the hydration-fix branch July 3, 2023 12:22
@github-actions github-actions bot mentioned this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants