Skip to content

Conversation

@dummdidumm
Copy link
Member

not sure how to add a test for this yet, as it needs to compilations, one for ssr one for client hydration

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint
@vercel
Copy link

vercel bot commented Jun 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-dev-2 ❌ Failed (Inspect) Jun 16, 2023 4:16pm
@dummdidumm dummdidumm added this to the 4.x milestone Jun 16, 2023
@benmccann
Copy link
Member

.svelte-kit/output/client/_app/immutable/nodes on version-4 is 179.1kB and on this branch is 179.0 kB. I didn't think it'd get smaller!

@dummdidumm
Copy link
Member Author

That's honestly surprising, since this change makes less things be matched by the data-svelte-h optimization - but maybe in this specific case it's actually smaller in the end because it results in less code?
Either way, gonna merge this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants