feat: css units in fly & blur transitions #7623
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For the
fly
transition, the x & y are passed as numbers and are used are pixel values (px)This limits the range of what fly can do.
This PR adds support for passing the x & y as strings that can contain CSS units:
You can create an animation that are relative:
'100%'
is based on the width of the box.Or based on the viewport:
Other units are also supported, we use
rem
a lot,currently we are calculating the px value or accept that the animation doesn't scale.
With this PR we would be able to write:
As a guideline for the regex I looked at css notation.
'100%' ✅
'100 %' ❌
If no unit is provided it falls back to using px. '50' is interpreted as '50px'
Closes #6050
Before submitting the PR, please make sure you do the following
[feat]
,[fix]
,[chore]
, or[docs]
.Tests
npm test
and lint the project withnpm run lint