[fix] do not collapse whitespace-only css vars #7303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member Author
| This should also fix the issue with |
Member
baseballyama left a comment
baseballyama left a comment There was a problem hiding this comment.
I commented on a related issue, so I could understand this PR.
And I think it's LGTM!
| ? this.node.value.children[0] | ||
| : this.node.value; | ||
| | ||
| if (first.type === 'Raw' && /^\s+$/.test(first.value)) return; |
Member
There was a problem hiding this comment.
I checked that the below statement is a syntax error. So this regex is ok.
div { --foo:; } Member
There was a problem hiding this comment.
@geoffrich Perhaps it would be useful to put a code comment here as to why we check this, since this applies specifically to chrome only.
Member Author
There was a problem hiding this comment.
I added an explanatory comment, thanks for the suggestion!
bluwy approved these changes Feb 23, 2022
himanshiLt pushed a commit to himanshiLt/svelte that referenced this pull request Mar 3, 2022
Fixes sveltejs#7152, see also sveltejs#7288 --foo:; used to be an invalid CSS custom property value, while -foo: ; was valid. By collapsing the whitespace in these declaration values, we were breaking scenarios where an empty custom property was desired. The spec was updated to trim whitespace and treat these values identically, but Chromium browsers still treat --foo; as invalid. This was recently fixed and will be released in Chrome 99, but this would still be a good fix to maintain backwards compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #7152, see also #7288
--foo:;used to be an invalid CSS custom property value, while-foo: ;was valid. By collapsing the whitespace in these declaration values, we were breaking scenarios where an empty custom property was desired.Note that the spec was updated to trim whitespace and treat these values identically, but Chromium browsers still treat
--foo;as invalid. This was recently fixed and will be released in Chrome 99, but this would still be a good fix to maintain backwards compatibility.Before submitting the PR, please make sure you do the following
[feat],[fix],[chore], or[docs].Tests
npm testand lint the project withnpm run lint