fix: Added the "off" value to the TS definition for textarea's wrap attribute #17326
+6 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 55f493d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Member
| MDN mark this value as "non-standard", and the HTML spec only mentions "hard" and "soft". We usually won't add non-standard/experimental features to the type definition unless they're widely used. |
Member
| Agree that in general we should be wary of adding non-standard things, but given that this is supported by all major browsers I think it's reasonable to allow it |
Rich-Harris approved these changes Dec 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Because the TypeScript definition for the
wrapattribute of thetextareaelement doesn't explicitly mention theoffvalue, a code problem is generated despite the major browsers not having any issue with the non-standard attribute value.https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/textarea#wrap