Skip to content

Conversation

@Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Dec 5, 2025

A <video> without a child <track kind="captions"> element yields an a11y warning. This is unhelpful in the case where, for example, the element in question is being used to show a MediaStream (e.g. the user's webcam).

We could debate whether the warning should be relaxed altogether (not every video needs captions) but I think there's probably value in keeping it and requiring the developer to be explicit about that fact when there's a src. But when there is no src, the warning feels misplaced.

Accompanies #17310

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint
@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2025

🦋 Changeset detected

Latest commit: 0029c5d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Playground

pnpm add https://pkg.pr.new/svelte@17311 
Copy link
Member

@paoloricciuti paoloricciuti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna approve in case you need a thumb for it but maybe we should wait for an a11y expert for this?

cc @geoffrich

Copy link
Member

@geoffrich geoffrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@paoloricciuti paoloricciuti merged commit 0990095 into main Dec 5, 2025
18 checks passed
@paoloricciuti paoloricciuti deleted the video-without-src branch December 5, 2025 22:59
@github-actions github-actions bot mentioned this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants