fix: warn on bidirectional control characters, fix various issues with template expressions #15893
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #6890 by warning if any bidirectional control characters are found in:
Additionally, I found and fixed a minor bug in the
build_template_chunk
andprocess_children
functions where certain nullish expressions wouldn't be coallesced to an empty string. I also noticed that the partial evaluation evaluatesBigInt
calls, which could throw, so I fixed it. Since these are very small changes, I don't think they necessitate a separate PR.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint