Skip to content

Conversation

Ocean-OS
Copy link
Member

Closes #6890 by warning if any bidirectional control characters are found in:

  • Any part of the source code
  • Escaped in a literal or template literal
  • A result of a partially evaluated expression

Additionally, I found and fixed a minor bug in the build_template_chunk and process_children functions where certain nullish expressions wouldn't be coallesced to an empty string. I also noticed that the partial evaluation evaluates BigInt calls, which could throw, so I fixed it. Since these are very small changes, I don't think they necessitate a separate PR.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint
Copy link

changeset-bot bot commented May 11, 2025

🦋 Changeset detected

Latest commit: cc7c317

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15893 
@Rich-Harris
Copy link
Member

It's always a good idea to fix separate bugs in separate PRs — in particular, if there are no tests then regressions are very likely

@Ocean-OS
Copy link
Member Author

I see, sorry for the issue. Should I remove the extra code from this PR?

@Rich-Harris
Copy link
Member

No need, the merge will take care of it!

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Rich-Harris Rich-Harris merged commit aa041a9 into sveltejs:main May 12, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants