fix: error on duplicate style and class directive #13097
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Svelte 5 rewrite
Closes #13095
I've also left a comment about the rest of the directives since i fell in the trap of try to add those tho only to discover they were already handled.
UPDATE: linting fortunately caught something i didn't realised could've been a problem. Something like this
Should actually be allowed, so i've fixed this bug...
i've slightly modified the test runner to assert that a code should not produce compiler errors so that i was able to also test for this. Let me know if it's not what we want, i can move the test in another suite but it seemed something that could be useful.scratch that, after a chat with Simon i moved the test tovalidatorand reverted the changes.Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4and notmain.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint