Skip to content

Conversation

@trueadm
Copy link
Contributor

@trueadm trueadm commented Jun 18, 2024

Fixes #12064

@changeset-bot
Copy link

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: e2b86eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this has come up a few times before and there's some reason it's like that. Will check again tomorrow. CC @jasonlyu123 who might remember

@jasonlyu123
Copy link
Member

beforeinput is always InputEvent so this should be fine. But input is only InputEvent with text-based input and textarea. It also not that the data field might be null or undefined, the instanceof InputEvent will also be false.

@trueadm
Copy link
Contributor Author

trueadm commented Jun 19, 2024

Not sure what to do about this then?

@dummdidumm
Copy link
Member

Nothing, this is a won't fix, they need to type-cast it in the method body.
We should document it in elements.d.ts though so we don't forget.

@trueadm trueadm closed this Jun 19, 2024
@dummdidumm dummdidumm deleted the fix-type branch June 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants