feat: added the prefer-svelte-reactivity rule

[marekdedic]

Closes #1071

[changeset-bot]

🦋 Changeset detected

Latest commit: 0996bb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
eslint-plugin-svelte	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@0996bb0 

Published Instant Preview Packages:

• eslint-plugin-svelte: https://pkg.pr.new/eslint-plugin-svelte@0996bb0

View Commit

[baseballyama]

I think we need to add tests for .svelte.js files also.

[marekdedic]

I think we need to add tests for .svelte.js files also.

Yes, I wanted to ask about whether that's something we're set up to do, I couldn't find any such tests on the repo...

[marekdedic]

@ota-meshi Can you please take a look at the test file? I tried the solution from eslint-community/eslint-utils#249 (comment), but it didn't work for me :/

[ota-meshi]

@marekdedic What have you tried? Have you added URL here?

eslint-plugin-svelte/packages/eslint-plugin-svelte/tests/utils/utils.ts

Line 18 in 3ddbd83

const globals = {

[marekdedic]

@marekdedic What have you tried? Have you added URL here?

That's exactly what I tried, but it didn't work :(

[ota-meshi]

Is it url01-input.svelte that you're saying didn't work? I've tried adding URL: 'readonly', URLSearchParams: 'readonly' to globals in your repository and it seems to work fine.

[marekdedic]

Ok, I was adding it in a different place and the value got overriden, thanks :)

[marekdedic]

I have re-implemented the PR so that it checks all the property calls and only reports if the variable is mutated.

[ota-meshi]

Awesome! Looks almost good to me, but I have two comments.

[ota-meshi]

LGTM! Thank you!

[ota-meshi]

@baseballyama Just to be sure, could you please check this PR?
This is a new rule that is included in the recommended config.

[baseballyama]

I will review it within a few days.👍

[marekdedic]

@baseballyama Gentle reminder :)

[baseballyama]

Sorry for late review!

[marekdedic]

No worries, I presume you also do this in your free time :)