fix(storage): read _base_url instead of _client.base_url inside signed url creation #1295
+4 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mandarini approved these changes Nov 3, 2025
grdsdev approved these changes Nov 3, 2025
Pull Request Test Coverage Report for Build 19042484437Details
💛 - Coveralls |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
After #1249, the storage client no longer should read the HTTPx client's
base_url, but should instead readself._base_url, as to not mutate objects passed in as shared. However, we are still reading the wrong URL insidecreate_signed_upload_url.The tests were passing before because they were also reading the same wrong variable, so the mistakes cancelled out.
Fixes #1294
Additional context
This is certainly confusing. I want to get rid of external
httpxclients for v3.0 as quickly as possible.