fix(storage): add upsert option for signed bucket #1283
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Currently there is no way to upsert with a signed upload url, this is because the
create_signed_upload_urlmethod doesn't have an option forupsert. This PR aims to fix this as theupsertshould be indicated at the URL creation stage and not at the upload stage.Additional context
Documentation change will need to happen for the Python reference docs too.
Fixes #1254