Skip to content

fix(realtime): handle websocket race condition in node.js #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
7ttp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(realtime): handle websocket race condition in node.js #1946

7ttp wants to merge 1 commit into from
+4 −0

Conversation

@7ttp
Copy link
Contributor

@7ttp 7ttp commented Dec 13, 2025

when using the ws module in node.js, the websocket can connect before the onopen handler is attached. this causes subscriptions to timeout because _onConnOpen never fires.

this fix checks readyState after setting up handlers and manually triggers _onConnOpen if the connection is already open.

closes #1559

cc @mandarini
@7ttp 7ttp requested review from a team as code owners December 13, 2025 10:59
@mandarini mandarini added the realtime-js Related to the realtime-js library. label Dec 15, 2025
@mandarini mandarini self-assigned this Dec 15, 2025
@coveralls
Copy link

coveralls commented Dec 15, 2025 •
edited
Loading

Coverage Status

coverage: 95.367% (+14.1%) from 81.261%
when pulling 9f9d819 on 7ttp:fix44
into 31280b2 on supabase:master.
depthfirst-app[bot]
depthfirst-app bot reviewed Dec 15, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

realtime-js Related to the realtime-js library.

3 participants

@7ttp @coveralls @mandarini