Skip to content

fix(auth): remove redirection in getAuthorizationDetails #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

fix(auth): remove redirection in getAuthorizationDetails #1811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27d0d70
fix(auth): no redirect in `getAuthorizationDetails`
cemalkilic Oct 29, 2025
263d105
fix(auth): format
cemalkilic Oct 29, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions packages/core/auth-js/src/GoTrueClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3362,10 +3362,13 @@ export default class GoTrueClient {
/**
* Retrieves details about an OAuth authorization request.
* Only relevant when the OAuth 2.1 server is enabled in Supabase Auth.
*
* Returns authorization details including client info, scopes, and user information.
* If the API returns a redirect_uri, it means consent was already given - the caller
* should handle the redirect manually if needed.
*/
private async _getAuthorizationDetails(
authorizationId: string,
options?: { skipBrowserRedirect?: boolean }
authorizationId: string
): Promise<AuthOAuthAuthorizationDetailsResponse> {
try {
return await this._useSession(async (result) => {
Expand All @@ -3389,17 +3392,7 @@ export default class GoTrueClient {
{
headers: this.headers,
jwt: session.access_token,
xform: (data: any) => {
// If the API returns redirect_uri, it means consent was already given
if (data.redirect_uri) {
// Automatically redirect in browser unless skipBrowserRedirect is true
if (isBrowser() && !options?.skipBrowserRedirect) {
window.location.assign(data.redirect_uri)
}
}

return { data, error: null }
},
xform: (data: any) => ({ data, error: null }),
}
)
})
Expand Down
10 changes: 5 additions & 5 deletions packages/core/auth-js/src/lib/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1655,14 +1655,14 @@ export interface AuthOAuthServerApi {
* Used to display consent information to the user.
* Only relevant when the OAuth 2.1 server is enabled in Supabase Auth.
*
* This method returns authorization details including client info, scopes, and user information.
* If the response includes a redirect_uri, it means consent was already given - the caller
* should handle the redirect manually if needed.
*
* @param authorizationId - The authorization ID from the authorization request
* @param options - Optional parameters including skipBrowserRedirect
* @returns Authorization details including client info and requested scopes
*/
getAuthorizationDetails(
authorizationId: string,
options?: { skipBrowserRedirect?: boolean }
): Promise<AuthOAuthAuthorizationDetailsResponse>
getAuthorizationDetails(authorizationId: string): Promise<AuthOAuthAuthorizationDetailsResponse>

/**
* Approves an OAuth authorization request.
Expand Down