feat(auth): support throwing errors instead of returning them #1766
   +225   −121      
   Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.    
 
Moved from: supabase/auth-js#1022
Author: @kiwicopple
Fixes #1688
Add support for
throwOnErroroption inAuthClientto throw errors instead of returning them.GoTrueClient Changes:
throwOnErroroption toGoTrueClientconstructor.throwOnErroris true.signUp,signInWithPassword,updateUser, and others to throw errors ifthrowOnErroris true.AuthClient Changes:
AuthClientto passthrowOnErroroption toGoTrueClient.Tests:
test/GoTrueClient.test.tsto verifythrowOnErrorfunctionality.Other changes
ConstructorParametersReplace
ConstructorParameterstype extraction with direct import ofGoTrueClientOptions:This was introduced because
ConstructorParameterswasn't resolving properly across package boundaries. Direct type extension is more explicit and ensures all auth-js properties are recognized.Other
Also fix two test failures in the throwOnError feature:
Issue:
_initialize()inGoTrueClient.tsaccessedwindow.location.hrefwithout checking if running in a browser environment, causingNode.jstests to fail withReferenceError: window is not defined.Root Cause: This bug was introduced in commit f9775cf but wasn't caught until this PR added new tests that instantiate
SupabaseClientdirectly in Node.js environment.Fix: Wrap URL parsing in an
isBrowser()check, consistent with how browser APIs are accessed elsewhere in the codebase.signInWithSSO()Issue: Test
signInWithSSO() should return error shape; calling code can opt to throwexpected the error to be returned instead of thrown, causing test failure.Root Cause: The test was incorrectly written when added in commit 002886a. The test name suggested alternative behavior, but this contradicts the feature design and all other tests in the suite.
Why this is a test bug, not a code bug:
Feature Design:
throwOnErroris a client-level setting. WhenthrowOnError: true, ALL methods throw on error consistently via the_returnResult()helper.Test Suite Consistency: All other tests in the
GoTrueClient with throwOnError optionsuite expect throws:signUp()expects throwsignInWithPassword()expects throwupdateUser()expects throwsignInWithOtp()expects throwsignInWithSSO()expected return (incorrect)signInWithSSO()uses_returnResult()just like all other methods - there's no special case handling.Fix: Update test to expect throwing behavior and rename to accurately reflect what it tests.