feat: add gravity support for imgproxy #402
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7103078200
💛 - Coveralls |
fenos reviewed Dec 27, 2023
fenos approved these changes Jan 3, 2024
| hey @fenos , we also need this one right? |
itslenny reviewed Apr 29, 2025
| if ( | ||
| !( | ||
| options.x_offset && | ||
| options.y_offset && |
There was a problem hiding this comment.
Is 0 a valid value for this? This would throw if x or y is 0 because 0 is "falsey" ... maybe replace it with isNaN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feat: add gravity param support for imgproxy transformation feature
Additional context
https://github.com/supabase/api-gateway/pull/352
https://imgproxy.net/blog/perfect-cut-smart-image-resizing-with-imgproxy/